Skip to content

5810: Add new shutdown emr serverless application lambda into the cdk app #5846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Oct 28, 2025
Merged

5810: Add new shutdown emr serverless application lambda into the cdk app #5846

merged 9 commits into from
Oct 28, 2025

Conversation

@Rob9786
Copy link
Collaborator

@Rob9786 Rob9786 commented Oct 15, 2025 •
edited
Loading

Make sure you have checked all steps below.

Issue

Tests

  • My PR adds the following tests based on our test strategy OR does not need testing for this extremely good reason:
    • No new tests

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it, or I have linked to a
    separate issue for that below.
  • If I have added new Java code, I have added Javadoc that explains it following our conventions and style.
  • If I have added or removed any dependencies from the project, I have updated the NOTICES file.

@Rob9786 Rob9786 linked an issue Oct 15, 2025 that may be closed by this pull request
Add new shutdown EMR Serverless application lambda into the CDK app #5810
Closed
@patchwork01 patchwork01 changed the base branch from develop to 5375-shut-down-emr-severless-bulk-import-stack October 22, 2025 10:13
Base automatically changed from 5375-shut-down-emr-severless-bulk-import-stack to develop October 22, 2025 10:19
@Rob9786
Copy link
Collaborator Author

Rob9786 commented Oct 27, 2025

Test 1:
Stood up CloudFormation stack. Didn't initiate a bulk import job but deleted the stack. The stack deleted cleanly.

Test 2:
Stood up CloudFormation stack. Initiated a bulk import. Waited until job progressed from pending->scheduled->running in EMR Studio. Deleted the stack. Job in EMR Studio changed to cancelled. Stack deleted cleanly.

@Rob9786
Copy link
Collaborator Author

Rob9786 commented Oct 27, 2025

Test 3:
Re-ran Test 2 after latest changes. Bulk import started. Stack was deleted and all resources were cleaned up correctly.

@Rob9786 Rob9786 added the needs-reviewer Pull requests that need a reviewer to be assigned label Oct 27, 2025
@Rob9786 Rob9786 marked this pull request as ready for review October 27, 2025 14:15
@patchwork01 patchwork01 removed the needs-reviewer Pull requests that need a reviewer to be assigned label Oct 27, 2025
@Rob9786 Rob9786 merged commit 836b6b8 into develop Oct 28, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@patchwork01 patchwork01 patchwork01 approved these changes

Assignees

@Rob9786 Rob9786

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add new shutdown EMR Serverless application lambda into the CDK app

3 participants

@Rob9786 @patchwork01